fix: correct preflight e2e health check port from 8080 to 8787#145
Merged
fix: correct preflight e2e health check port from 8080 to 8787#145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--preflight-http-listen 127.0.0.1:8787but the CI health check was pollinghttp://127.0.0.1:8080/preflight, causing the preflight readiness check to fail.Description
${EVIDENCEOS_PREFLIGHT_URL}/preflightin.github/workflows/ci.ymlso the health-check polling uses the job env var (which is set tohttp://127.0.0.1:8787) and aligns with the daemon startup address.Testing
grep/rg) to locate references and verified the updated line in.github/workflows/ci.yml, and no full CI or integration test suite was run in this environment because the../EvidenceOScheckout/build could not be exercised here.Codex Task