fix: improve preflight e2e daemon readiness diagnostics#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
http://127.0.0.1:8787/preflightwithin the timeout, and failure logs were not immediately visible in the job output.--data-dirparent directory can cause the daemon to crash on startup, so ensure the path exists before launching the daemon./preflight,/health,/), so broaden the probe to avoid false failures when a different route is served.Description
mkdir -p artifacts/preflight-e2e/datain the workflow start step./preflight,/health, and/for HTTP 200 during the 60-second warm-up loop and update the failure message accordingly.artifacts/preflight-e2e/daemon.log,artifacts/preflight-e2e/daemon.pid, and aps aux | grep evidenceosprocess listing to surface daemon startup diagnostics in the job log.Testing
git diff --check -- .github/workflows/ci.ymland it completed with no warnings or whitespace errors.Codex Task