Skip to content

Fix cargo fmt and clippy CI failures in http_preflight#287

Open
Copilot wants to merge 3 commits intomainfrom
copilot/fix-model-functionality-issue
Open

Fix cargo fmt and clippy CI failures in http_preflight#287
Copilot wants to merge 3 commits intomainfrom
copilot/fix-model-functionality-issue

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

cargo fmt --check and cargo clippy were both failing in CI, blocking the test_evidence.sh bootstrap stage.

Changes

  • Formatting (http_preflight.rs, http_preflight_tests.rs): Applied cargo fmt --all to fix line-length violations in method chains and function call chains.
  • Missing struct field (http_preflight.rs): test_state() helper was initializing HttpPreflightState without postflight_etl_path, added after the struct was extended. Fixed by adding postflight_etl_path: PathBuf::from("/dev/null") — writes are discarded, no test semantics change.
  • .gitignore: Added crates/*/artifacts/ and proptest-regressions/ to prevent test-generated files from being tracked.

Related references

  • AGENTS.md
  • TESTING_EVIDENCE.md
  • docs/TEST_EVIDENCE.md
  • docs/TEST_COVERAGE_MATRIX.md

Change type

  • Bug fix
  • Feature
  • Refactor
  • Docs only
  • Test-only

Protocol and safety impact

  • No protocol logic changes
  • Determinism impact reviewed (ordering/hash/canonicalization)
  • Panic risk reviewed on request/runtime paths
  • Network-facing inputs validated fail-closed
  • No secrets/raw payloads added to logs

Testing checklist

  • Tests are black-box (public APIs/external behavior)
  • Tests do not copy/paste production logic into assertions
  • Numeric boundary cases are tested
  • Deterministic functions/flows include determinism assertions
  • cargo fmt --check passes
  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • No new unsafe code

Evidence

CI run that surfaced both failures: https://github.com/jverdicc/EvidenceOS/actions/runs/22513733985/job/65227872047#step:19:1

Original prompt

Reference: https://github.com/jverdicc/EvidenceOS/actions/runs/22513733985/job/65227872047#step:19:1

Fix this without changing important functionality of the model and system.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Mar 1, 2026
@jverdicc jverdicc marked this pull request as ready for review March 1, 2026 00:27
Copilot AI and others added 2 commits March 1, 2026 00:47
…d missing postflight_etl_path field in test_state

Co-authored-by: jverdicc <23726212+jverdicc@users.noreply.github.com>
…tes/*/artifacts/ and proptest-regressions/

Co-authored-by: jverdicc <23726212+jverdicc@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix model functionality without major changes Fix cargo fmt and clippy CI failures in http_preflight Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants