Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
commit_artifactswhen ASPEC rejects a wasm module while thestate.claimslock is still held, which causedgolden_execute_claim_capsule_hash_and_etl_index_stableto hang indefinitely.Description
commit_artifacts(crates/evidenceos-daemon/src/server/handlers_v2.rs) to record ASPEC rejection under theclaimslock, set a localaspec_rejectedflag, drop the lock, callpersist_all_with_trial_router, and only then return theFailedPreconditionerror if the module was rejected (avoids persisting while holdingclaims).crates/evidenceos-daemon/src/server/core.rs) to assert the deterministic ASPEC rejection behavior for the burn wasm module and wrap the test body intokio::time::timeout(Duration::from_secs(10), ...)so hangs fail fast with a clear message.Testing
cargo fmt --check, which succeeded.cargo test -p evidenceos-daemon --lib server::tests::golden_execute_claim_capsule_hash_and_etl_index_stable -- --nocapture, which passed after the fix.cargo test --workspace), but the full workspace run was not completed here due to long compile/test runtime in this environment.Codex Task