Harden public repo security and validation#1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3a5fbd59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const phraseWords = phrase.trim().split(/\s+/).map(normalise).filter(Boolean); | ||
| if (phraseWords.length === 0) { |
There was a problem hiding this comment.
Preserve non-ASCII passphrases in extraction
Normalizing phraseWords with normalise(...).filter(Boolean) before any matching makes passphrases written in non-ASCII scripts (for example Japanese or Cyrillic) collapse to an empty token list, which now forces passphraseFound to false even when the transcript contains the exact phrase. Before this change, the non-aligner path used a direct case-insensitive substring check and would accept such phrases; this regression blocks multilingual passphrase workflows entirely.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,97 @@ | |||
| import { sanitizeMessage } from "./redaction.js"; | |||
|
|
|||
| const DEFAULT_TIMEOUT_MS = 120_000; | |||
There was a problem hiding this comment.
Avoid global 120s timeout for daemon requests
Setting a default 120-second timeout in the shared daemonFetch helper applies to all bridge operations (including synthesis/transcription calls) and can abort valid long-running requests, returning a generic daemon-unavailable error even when the daemon is healthy. Since this wrapper is now used across tools, the new hard cap introduces request failures for larger inputs that previously completed successfully.
Useful? React with 👍 / 👎.
957957c to
04d2111
Compare
04d2111 to
9e24524
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Summary
Validation