Stabilize Roborazzi baseline output paths and snapshot workflow docs#146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
mobile/build.gradleto run snapshot-only tests for Roborazzi tasks by detecting task names and to include snapshot patterns when recording (include '**/snapshots/**') while excluding them for normal runs.wear/build.gradlewith the same Roborazzi task gating and add CI Robolectric offline system properties (robolectric.offlineandrobolectric.dependency.dir) so CI/offline runs can use a pre-populated Robolectric cache.ComposePreviewSnapshotTests.kt) to write deterministic baseline PNGs undersrc/test/snapshots/roborazzi/ComposePreviewSnapshotTests/<testName>.pngso golden images are stable and commit-able..gitignorerules to ignore Roborazzi diff/actual/compare artifacts while allowing thesrc/test/snapshotsbaselines to be tracked.README.md(how to run./gradlew :mobile:recordRoborazziDebug :wear:recordRoborazziDebugand commit updated baselines with UI changes).Testing
./gradlew clean :mobile:recordRoborazziDebug :wear:recordRoborazziDebugfrom a clean environment to validate the configuration and task gating, but snapshot recording did not complete because Robolectric attempted to fetch instrumented Android artifacts and the container environment reportedNetwork is unreachable.ComposePreviewSnapshotTestsdue toFailed to fetch maven artifact org.robolectric:android-all-instrumented), so no golden PNGs were produced in this environment..gitignorewere applied and validated syntactically; when run in a network-enabled or Robolectric-offline-prepared environment the recording command will emit baselines to the newly-configured tracked paths.Codex Task