fix (test_api_public): patched a bug in API test (get request freezed)#140
fix (test_api_public): patched a bug in API test (get request freezed)#140mdevolde merged 1 commit intojxmorris12:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test freeze issue in the public API test by implementing a timeout mechanism and adjusting CI configuration. The test was previously skipped on CI due to potential freezing issues, but now runs with proper timeout protection.
- Removed the CI skip marker from
test_api_public.pyto allow the test to run in CI environments - Implemented a timeout wrapper using
concurrent.futures.ThreadPoolExecutorto prevent test hangs - Changed pytest parallelization from auto workers to single worker to avoid concurrency conflicts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_api_public.py | Refactored test to use timeout wrapper with concurrent.futures, removed CI skip marker, and improved exception handling |
| .github/workflows/test.yml | Added manual workflow trigger and changed pytest workers from auto to 1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Finally removed pytest-xdist to resolve the issue, without any other needed fix. |
fix (test_api_public): patched a bug in API test (get request freezed)
Why the pull request was made
To prevent the CI from failing when the library code is compliant.
Summary of changes
Screenshots (if appropriate):
Not applicable.
How has this been tested?
Made CI executions on my fork.
Resources
Not applicable.
Types of changes
Checklist