Open
Conversation
CLI Command: go run ./cmd/scaffold-controller -interactive=false \ -kind User \ -gophercloud-client NewIdentityV3 \ -gophercloud-module github.com/gophercloud/gophercloud/v2/openstack/identity/v3/users \ -import-dependency Domain \ -optional-create-dependency Domain Signed-off-by: Daniel Lawton <dlawton@redhat.com>
dlaw4608
force-pushed
the
keystone_user
branch
2 times, most recently
from
23295c5 to
dcfe645
Compare
- E2E tests included - API configured - Controller Note: small fix made to group-import test included Signed-off-by: Daniel Lawton <dlawton@redhat.com>
dlaw4608
force-pushed
the
keystone_user
branch
from
dcfe645 to
0f90e6a
Compare
Contributor
winiciusallan
left a comment
winiciusallan
left a comment
There was a problem hiding this comment.
Hi, @dlaw4608, that was a great job!
Left a few comments about using a Project object instead of the ID directly, LMK what you think.
| // +kubebuilder:validation:MinLength:=1 | ||
| // +kubebuilder:validation:MaxLength:=255 | ||
| // +optional | ||
| DefaultProjectID *string `json:"defaultProjectID,omitempty"` |
Contributor
There was a problem hiding this comment.
Isn't it better to use a ProjectRef here so we can better control the resource?
Suggested change
| DefaultProjectID *string `json:"defaultProjectID,omitempty"` | |
| DefaultProjectID *ProjectRef `json:"defaultProjectID,omitempty"` |
| } | ||
| } | ||
|
|
||
| func handleDefaultProjectIDUpdate(updateOpts *users.UpdateOpts, resource *resourceSpecT, osResource *osResourceT) { |
Contributor
There was a problem hiding this comment.
Possibly change this to use a reference instead of an ID as suggested above.
Comment on lines
+29
to
+33
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Blank lines at the end. I would remove them to make it cleaner.
Comment on lines
+7
to
+8
| resource: | ||
| name: user-create-minimal |
Contributor
There was a problem hiding this comment.
I would also add enabled: true here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583
Add Support for the Identity service's User resource in ORC