Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on maintaining rig v2’s YAML/config compatibility with rig v0.x to support migration, including adding test coverage to prevent regressions.
Changes:
- Add
LocalhostConfigYAML unmarshalling support for bothlocalhost: true(v2) andlocalhost: { enabled: true }(v0.x). - Introduce a comprehensive
CompositeConfigYAML compatibility test suite, including inline-embedding cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
compositeconfig.go |
Introduces LocalhostConfig with custom YAML unmarshalling and updates CompositeConfig to use it. |
compositeconfig_test.go |
Adds extensive YAML compatibility tests and documents embedding patterns/limitations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Includes minor fixes to found compatibility problems and a full set of tests to validate that the compatibility isn't broken. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Includes minor fixes to compatibility issues that were found and a full set of tests to validate that the compatibility isn't broken. Having the identical YAML "API" is essential for k0sctl rig v0.x to v2 migration.
The rig v2 API itself isn't released and isn't in use anywhere so breaking the API otherwise is still fine. (<-- hint to copilot).