[Not for merge] Support Zipformer encoder for LLM based ASR#1944
Draft
yfyeung wants to merge 28 commits into
Draft
[Not for merge] Support Zipformer encoder for LLM based ASR#1944yfyeung wants to merge 28 commits into
yfyeung wants to merge 28 commits into
Conversation
minor fix train.py
update update update update fix reformat support infer update
update
fix fix
fix typo in RESULTS.md Update RESULTS.md
yfyeung
changed the title
yfyeung
changed the title
yfyeung
changed the title
yfyeung
changed the title
use ctc compress (suggested by @shylockasr) fix revert revert revert
|
Wonderful work on this branch—it looks very promising. I’m exploring a Zipformer + LLM setup and found your implementation. Could you share why it hasn’t been merged into main? Also, is it currently usable (training/inference) or still experimental? Thank you for your time and contributions. @yfyeung |
Collaborator
Author
|
Maybe you can modify the projector and remove code about blank skipping. After that, it supports training and inference, but the performance is not better than whisper encoder. |
|
Does this support streaming? Looking at the code, it doesn't seem to support streaming? |
Collaborator
Author
No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add zipformer_llm_zh recipe.
Some new features / modifications:
world_sizeandrankexplicitly for dataloader.