fix: make python setup.py works for development mode#832
Conversation
namely, install by bellow cmds works: `python setup.py develop` or `pip install -e .`
|
Thanks for the contribution.
As developers, I would recommend you to read https://k2-fsa.github.io/k2/installation/for_developers.html, which does not use |
|
Yeah, I read that doc. But python develop mode is a common routine for developers, e.g. it requires nothing to do after you change python sources. And if c++ sources change, just pip install -e ., instead of firstly make and others. And u don't need an env shell to source. |
|
I think it would be nice if setup.py were to support development mode, but I don't understand how this change accomplishes that. Is the empty string supposed to be a key for that |
I think the old code should work, But not, I think there's a bug of setuptool pkg, and make a PR: pypa/setuptools#2803. And we could wait for their answers, it's not critical for us anyway. |
namely, install by bellow cmds works:
python setup.py developorpip install -e .