Refactor container-shell#1516
Draft
kachick wants to merge 7 commits into
Draft
Conversation
kachick
commented
Mar 23, 2026
kachick
commented
Owner
- Fix ps error in bash when PPID is 0
- Modularize bash-to-zsh switcher logic
- Fix misleading comment in bash-zsh-switcher package
- Remove redundant comments in bash-zsh-switcher package
- Fix lint errors and improve linter file collection
- Use array for conditional login option in bash-zsh-switcher
- Use highly compatible conditional expansion for login option
- Restore comments and structure bash-zsh-switcher as a function
- Extract logic to pkgs/local/bash-zsh-switcher - Use replaceVars to inject Nix paths into the shell script - Simplify home-manager/bash.nix by reading the generated script - This improves maintainability and allows for easier testing/shellchecking Assisted-by: Gemini CLI <gemini-cli@google.com>
- Fix SC2086 in bash-zsh-switcher.bash (quote $LOGIN_OPTION) - Improve internal/fileutils/walker.go to exclude directories from bash/nix file lists - Apply treefmt formatting Assisted-by: Gemini CLI <gemini-cli@google.com>
This replaces bash arrays with ${VAR+"$VAR"} to ensure compatibility
with older Bash versions (like 3.2 on Darwin) and satisfies shellcheck.
Assisted-by: Gemini CLI <gemini-cli@google.com>
- Restore optimization and cross-platform compatibility comments - Wrap logic in a function and call it explicitly in bash.nix - Clean up the function after execution with unset -f - This maintains high visibility and portability Assisted-by: Gemini CLI <gemini-cli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.