feat: add pre-commit hooks, linting, and Claude Code setup#70
Open
feat: add pre-commit hooks, linting, and Claude Code setup#70
Conversation
- Extend .pre-commit-config.yaml with local DCO commit-msg hook - Add `make fmt` target (ruff format) - Create CLAUDE.md with repo overview, commands, and conventions - Add .claude/settings.json with allowed Bash permissions - Add scripts/hooks/commit-msg to enforce DCO sign-off and block Co-Authored-By AI attribution (use Assisted-By instead) Pre-commit install: `pre-commit install --hook-type pre-commit --hook-type commit-msg` Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
evaline-ju
reviewed
Mar 13, 2026
make lint runs pre-commit --all-files which includes ruff-format (via the ruff-pre-commit hook). A separate make fmt target is redundant. Addresses review comment from evaline-ju on PR #70. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
Collaborator
Author
|
Addressed @evaline-ju's comment: removed the |
evaline-ju
reviewed
Mar 13, 2026
| "Bash(ls:*)", | ||
| "Bash(find:*)", | ||
| "Bash(make lint:*)", | ||
| "Bash(make fmt:*)", |
Contributor
There was a problem hiding this comment.
nit: this one doesn't exist anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of repo orchestration — establishes the code quality baseline.
.pre-commit-config.yaml: extends existing hooks with a localcommit-msghook that enforces DCO sign-off and blocksCo-Authored-ByAI attribution (requiresAssisted-Byinstead)Makefile: addsmake fmttarget usingruff formatCLAUDE.md: repo overview with structure, key commands, code style, and DCO guidance for Claude Code sessions.claude/settings.json: allowed Bash permissions for Claude Code auto-approvalscripts/hooks/commit-msg: hook script enforcing DCO and AI attribution conventionInstall hooks
Test plan