-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add security governance (CODEOWNERS, SECURITY.md, .gitignore hardening) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pdettori
wants to merge
2
commits into
main
Choose a base branch
from
orchestrate/security
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # CODEOWNERS | ||
| # | ||
| # Defines code ownership for automatic review requests on pull requests. | ||
| # Owners are notified when files in their area are changed. | ||
| # | ||
| # Syntax: <pattern> <owner> [<owner> ...] | ||
| # Patterns follow .gitignore rules. Last matching rule wins. | ||
| # | ||
| # Reference: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | ||
|
|
||
| # Default: all maintainers review everything | ||
| * @kagenti/plugin-adapters-maintainers | ||
|
|
||
| # CI and developer tooling | ||
| .github/ @kagenti/plugin-adapters-maintainers | ||
| Makefile @kagenti/plugin-adapters-maintainers | ||
| pyproject.toml @kagenti/plugin-adapters-maintainers | ||
| .pre-commit-config.yaml @kagenti/plugin-adapters-maintainers | ||
|
|
||
| # Core server implementation — highest impact changes | ||
| src/ @kagenti/plugin-adapters-maintainers | ||
|
|
||
| # Plugin framework and examples | ||
| plugins/ @kagenti/plugin-adapters-maintainers | ||
|
|
||
| # Documentation and governance | ||
| *.md @kagenti/plugin-adapters-maintainers | ||
| CODEOWNERS @kagenti/plugin-adapters-maintainers | ||
| SECURITY.md @kagenti/plugin-adapters-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # Security Policy | ||
|
|
||
| ## Reporting a Vulnerability | ||
|
|
||
| Please report security vulnerabilities through GitHub Security Advisories — | ||
| **do NOT open public issues for security bugs**. | ||
|
|
||
| **[Report a vulnerability →](https://github.com/kagenti/plugins-adapter/security/advisories/new)** | ||
|
|
||
| Include: | ||
| - A clear description of the vulnerability | ||
| - Steps to reproduce | ||
| - Potential impact assessment | ||
| - Any suggested mitigations (optional) | ||
|
|
||
| ## Response Timeline | ||
|
|
||
| | Stage | Target | | ||
| |-------|--------| | ||
| | Acknowledgment | Within 48 hours | | ||
| | Initial assessment | Within 7 days | | ||
| | Status update | Weekly until resolved | | ||
| | Credit | In the security advisory (if desired) | | ||
|
|
||
| ## Supported Versions | ||
|
|
||
| | Version | Supported | | ||
| |---------|-----------| | ||
| | `main` | ✅ | | ||
|
|
||
| Older tagged releases receive security fixes on a best-effort basis. | ||
|
|
||
| ## Security Controls | ||
|
|
||
| This repository implements the following security measures: | ||
|
|
||
| | Control | Tool | | ||
| |---------|------| | ||
| | Dependency vulnerability scanning | Trivy (CRITICAL/HIGH on PRs) | | ||
| | Dependency updates | Dependabot (weekly, all ecosystems) | | ||
| | Python SAST | Bandit (HIGH severity blocks PRs) | | ||
| | Code analysis | CodeQL (security-extended queries) | | ||
| | Dockerfile lint | Hadolint | | ||
| | Secret detection | Pre-commit hooks | | ||
| | Supply chain | OpenSSF Scorecard (weekly), SHA-pinned actions | | ||
| | License compliance | Dependency Review Action (GPL/AGPL blocked) | | ||
|
|
||
| ## Security-Sensitive Areas | ||
|
|
||
| Changes to the following require extra scrutiny: | ||
|
|
||
| - `src/server.py` — gRPC ext-proc server handling all traffic | ||
| - `plugins/` — Plugin interface and example implementations | ||
| - `.github/workflows/` — CI/CD pipeline | ||
| - `Dockerfile` — Container image | ||
|
|
||
| ## Disclosure Policy | ||
|
|
||
| We follow coordinated disclosure. Once a fix is available: | ||
| 1. A security advisory is published on GitHub | ||
| 2. A new release tag is pushed | ||
| 3. The advisory is made public (typically 7 days after the fix is released) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.