Conversation
3a2ba5c to
8533820
Compare
|
FYI this also fixes the following Clippy error 🎉 warning: this expression borrows a reference (`&mut W`) that is immediately dereferenced by the compiler
--> /path/to/file_html.rs:79:15
|
79 | foo(&mut _ructe_out_)?;
| ^^^^^^^^^^^^^^^^ help: change this to: `_ructe_out_`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow |
Contributor
|
Any news on when/if this will be merged? Or a way to suppress the clippy lint mentioned by @OskarPersson ? |
Owner
Author
Contributor
|
Would be cool to have this fixed, so CI pipelines with clippy will pass again :) |
8533820 to
c80eafe
Compare
c80eafe to
8127f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
I hope to enable #88 with this signature change, but that doesn't really seem to happen with the change currently in this PR. So I might try a slightly different signature.