Recursive rewrite of rendering datasources for subitems of branch item#4
Open
BonNil wants to merge 2 commits intokamsar:masterfrom
Open
Recursive rewrite of rendering datasources for subitems of branch item#4BonNil wants to merge 2 commits intokamsar:masterfrom
BonNil wants to merge 2 commits intokamsar:masterfrom
Conversation
Owner
|
Hi there! Thanks for the contribution. #2 I believe implemented the same thing, and I've merged that PR. If yours adds capabilities that that merge didn't, please feel free to adapt your PR to fit in with it and I'll merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kam! Big fan of the all the work you do on Sitecore tools, always elegantly written and extremely useful!
I recently found myself in need of local rendering datasources for a particular branch template. A quick google and I found this gem, works like a charm for the instance of the branch item! However, I needed to do the same for subitems, so I extended your software a bit and made it recursively handle rendering datasources for all subitems of the branch item as well.
Hope you have time to look at it and maybe merge it into your branch!
Best wishes,
Bonny