Simplify the run scripts#735
Open
asarhaddon wants to merge 10 commits into
Open
Conversation
Shebangs are convenient, but not portable, and they increase the complexity. Most were ignored for the more general "run" script.
This change is split so that git shows meaningful diffs.
The convention was already applied de facto:
* {latex3,scala}/run start by changing their working directory, so
relative paths in command line arguments must be relative to the
implementation directory.
* bbc-basic: contains '-path ../bbc-basic', so it assumes that it is
executed in an implementation directory (even if not necessary its
own).
* impls/matlab/run already seems to assume that is is executed in its
directory.
It also fixes the execution of $path_with_spaces/impls/vimscript/run.
Take the opportunity to change most shebangs from '/usr/bin/env bash'
to 'bin/sh' because the latter is more portable, and more efficient
when both actually differ.
Also trigger all optional shell errors.
Contributor
Author
|
Rust fails because of an old docker image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
The idea was to use /bin/sh where possible. On Debian/Ubuntu, this is way faster than bash. Also, /usr/bin/env foo is not more portable than /usr/bin/foo, it just fails elsewhere.
A number of unrelated and small suggestions germed on the way. I can make distinct merge requests for the want you find useful and cannot cherrypick.
Rust fails, probably because of an outdated Docker image. The build succeeds on my machine.
Qbasic fails, although the changes in the directory are minimal, and safe for cbmbasic.
I failed to understand the issue.
Perl failed with a cryptic error, fixed by adding a --mal command line option disabling readline.
Purs fails with the same error than Perl. I have given up applying the same fix. Any change I introduce in src/Readline.js results in a new error.
Please tell me which changes are woth working on. I would also appreciate help about qbasic and purs.