Implementing the possibility of add new penalty of VertexSubtype#3
Open
magyargergo wants to merge 1 commit intokanthkumar46:masterfrom
Open
Implementing the possibility of add new penalty of VertexSubtype#3magyargergo wants to merge 1 commit intokanthkumar46:masterfrom
magyargergo wants to merge 1 commit intokanthkumar46:masterfrom
Conversation
…method in VertexSubtype enum.
magyargergo
changed the title
| } | ||
|
|
||
| public static void addPenalty(IVertexSubtype v1, IVertexSubtype v2, double value) { | ||
| penaltyMap.put(Tuple.of(v1, v2), value); |
Owner
There was a problem hiding this comment.
@magyargergo Javaslang HashMap is immutable by nature. This will create new instance of penaltyMap everytime addPenalty is called.
if you think this method adds value in future, consider changing penaltyMap type to java.util.HashMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Please take a review on this commit.
Regards,
Gergo