-
Notifications
You must be signed in to change notification settings - Fork 1
Replaced paste.ee export with Android file sharing #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkf
wants to merge
26
commits into
kapware:master
Choose a base branch
from
mkf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
34f3555
Introducing share button, we have errors, incl "At least one of messa…
mkf 49cbfbd
share-button react square brackets, string: Share-~ with sharing~
mkf 82ea7be
properly referred to adapt-react-class in share-class
mkf 79dc171
Unwrapped adapt-react-class Share
mkf b7c61da
Moved share to ui
mkf a8a31c0
share: clj->js content
mkf 1677d7d
Added react-native-fs
mkf 34e175d
Added react-native-fs to .re-natal modules
mkf 7a7adeb
Added Write to file button with its functionality without using react…
mkf 3475cbf
Added react-native-file-opener
mkf 4ea5965
Added file opening
mkf bb6116c
Added file sharing which doesn't work (at least on Android)
mkf 2a6801c
Added react-native-share
mkf a147d86
Added react-native-share to .re-natal
mkf ab3abd3
Added file sharing which works, at least on Android with the most imp…
mkf f14ed31
Removed paste.ee export and everything related
mkf eefcdca
Removed Write file & open
mkf a762acc
Removed react-native-file-opener
mkf a542ab6
Removed msg sharing
mkf 2b86b5d
Moved a-share-button defn down to before write-to-file-and-share-button
mkf baa0972
Renamed button: "Write to file &share" → "Export"
mkf d4e4760
Replaced write console logging with catch→alert as I don't know how t…
mkf 742c1dd
Changed the comment about :subject or :title to be more humane
mkf 982bef5
Renamed to share-button/3 & export-button/1; centered export button.
mkf 1759390
Made the comment about .-DocumentDirectoryPath more humane
mkf 46ee82d
Abstracted out alert function
mkf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| rootProject.name = 'auricle' | ||
| include ':react-native-share' | ||
| project(':react-native-share').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-share/android') | ||
| include ':react-native-fs' | ||
| project(':react-native-fs').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-fs/android') | ||
|
|
||
| include ':app' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,25 @@ | ||
| { | ||
| "name": "auricle", | ||
| "version": "0.0.1", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node node_modules/react-native/local-cli/cli.js start", | ||
| "test": "jest" | ||
| }, | ||
| "dependencies": { | ||
| "babel-plugin-transform-es2015-block-scoping": "6.15.0", | ||
| "react": "16.0.0-alpha.12", | ||
| "react-native": "0.46.1" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-jest": "20.0.3", | ||
| "babel-preset-react-native": "2.1.0", | ||
| "jest": "20.0.4", | ||
| "react-test-renderer": "16.0.0-alpha.12" | ||
| }, | ||
| "jest": { | ||
| "preset": "react-native" | ||
| } | ||
| } | ||
| "name": "auricle", | ||
| "version": "0.0.1", | ||
| "private": true, | ||
| "scripts": { | ||
| "start": "node node_modules/react-native/local-cli/cli.js start", | ||
| "test": "jest" | ||
| }, | ||
| "dependencies": { | ||
| "babel-plugin-transform-es2015-block-scoping": "6.15.0", | ||
| "react": "16.0.0-alpha.12", | ||
| "react-native": "0.46.1", | ||
| "react-native-fs": "^2.3.3", | ||
| "react-native-share": "^1.0.20" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-jest": "20.0.3", | ||
| "babel-preset-react-native": "2.1.0", | ||
| "jest": "20.0.4", | ||
| "react-test-renderer": "16.0.0-alpha.12" | ||
| }, | ||
| "jest": { | ||
| "preset": "react-native" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,3 @@ | |
| (fn [db _] | ||
| (:next-time db))) | ||
|
|
||
| (reg-sub | ||
| :api-key | ||
| (fn [db _] | ||
| (:api-key db))) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing redundant comment.