Skip to content

Fix timestamp format in LrcLyricParserTest #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andy840119 merged 2 commits into from
Jun 22, 2025
Merged

Fix timestamp format in LrcLyricParserTest #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9a910
Fix timestamp format in LrcLyricParserTest
Maxr1998 Jun 22, 2025
5afe88a
Add more test cases and comments for it.
andy840119 Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions LrcParser.Tests/Parser/Lrc/Lines/LrcLyricParserTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ namespace LrcParser.Tests.Parser.Lrc.Lines;

public class LrcLyricParserTest : BaseSingleLineParserTest<LrcLyricParser, LrcLyric>
{
[TestCase("[00:17:97]帰[00:18:37]り[00:18:55]道[00:18:94]は[00:19:22]", true)]
[TestCase("[00:17:97]<00:00.00>帰<00:00.00>り<00:00.00>道<00:00.00>は<00:00.00>", true)]
[TestCase("karaoke", true)] // depends on the config, might be parsed but no time, or being ignored.
[TestCase("[00:17.97]帰[00:18.37]り[00:18.55]道[00:18.94]は[00:19.22]", true)]
[TestCase("[00:17.97]<00:00.00>帰<00:00.00>り<00:00.00>道<00:00.00>は<00:00.00>", true)]
[TestCase("[00:17.97]", true)] // only start time-tag can be decode.
[TestCase("[00:17:97]", true)] // invalid time-tag might be decoded as lyric string with no time-tag info.
[TestCase("karaoke", true)] // string might be parsed into lyric without any time info for now.
[TestCase("", false)]
[TestCase(null, false)]
public void TestCanDecode(string text, bool expected)
Expand Down