Feat: Add media support to dive route markers and enhance preview UI#170
Merged
Feat: Add media support to dive route markers and enhance preview UI#170
Conversation
Implement the ability to attach photos, videos, or YouTube links to custom route markers. This includes a complete UI for selection, robust data persistence, and specialized handling for different media types. Key changes: - Implement `MarkerModal` media tab for selecting site or external media. - Ensure all media properties are persisted in GeoJSON and restored correctly during route edits. - Implement robust video previews using `<video>` elements with forced frame rendering (0.1s seek) and hover-to-play functionality. - Fix `NotAllowedError` in browsers by safely catching video play promises on hover. - Add specialized YouTube handling using generated thumbnails to fix CORB/ORB errors and improve loading performance. - Enhance the marker editor UI with permanent descriptive overlays on media items for easier identification. - Update `RouteDetail` marker popups to render images, video players, or YouTube embeds based on the attached media type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the ability to attach photos, videos, or YouTube links to custom route markers. This includes a complete UI for selection, robust data persistence, and specialized handling for different media types.
Key changes:
MarkerModalmedia tab for selecting site or external media.<video>elements with forced frame rendering (0.1s seek) and hover-to-play functionality.NotAllowedErrorin browsers by safely catching video play promises on hover.RouteDetailmarker popups to render images, video players, or YouTube embeds based on the attached media type.