Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

chore(deps): npm audit fix#154

Open
johnjbarton wants to merge 1 commit intokarma-runner:masterfrom
johnjbarton:deps
Open

chore(deps): npm audit fix#154
johnjbarton wants to merge 1 commit intokarma-runner:masterfrom
johnjbarton:deps

Conversation

@johnjbarton
Copy link
Copy Markdown
Contributor

No description provided.

@XhmikosR
Copy link
Copy Markdown
Contributor

IMO:

  1. I'd drop yarn.lock and use package-lock.json (assuming you are using Node.js >= 8.x locally)
  2. unfortunately, a dep messed up semver thus breaking old Node.js versions

"minimist": {
"version": "1.2.0",
"resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
"resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These kind of changes shouldn't happen with the latest Node.js >= 8.x.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
"resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",

Copy link
Copy Markdown

@AnjaPrivat AnjaPrivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files changed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants