Fix global state root when class root is empty#2
Open
Mohiiit wants to merge 1 commit intokarnotxyz:main-v0.14.1from
Open
Fix global state root when class root is empty#2Mohiiit wants to merge 1 commit intokarnotxyz:main-v0.14.1from
Mohiiit wants to merge 1 commit intokarnotxyz:main-v0.14.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When the class tree is empty, the global state root should equal the contract state root. The previous Cairo code only short-circuited when both roots were zero, which caused block 0 to hash
(GLOBAL_STATE_VERSION, contract_state_root, 0)and produce the wrong final root in SNOS.Validation
0x3c538d437670f4c6f72dd799f215a007720ec7d19bc64195c96399145d8746f