#39 Fixed bug where f-string was unterminated

[jathavaan]

This pull request refactors the way SQL filter strings are constructed for FKB and OSM IDs in the merge_fkb_osm method to improve readability and maintainability. The logic for building the filter strings is now separated into explicit string variables before use.

Refactoring for SQL filter construction:

• Refactored construction of the fkb_filter and osm_filter SQL filter strings by first joining the ID lists into string variables (ids_fkb_str and ids_osm_str), improving clarity and reducing code duplication. (src/infra/infrastructure/services/conflation_service.py, src/infra/infrastructure/services/conflation_service.pyL181-R185)

[Copilot]

Pull Request Overview

This pull request fixes a bug with an unterminated f-string in SQL filter construction and refactors the code for improved readability by separating the string joining logic from the conditional filter creation.

• Extracts ID list joining into separate variables (ids_fkb_str, ids_osm_str)
• Simplifies the ternary operator expressions for fkb_filter and osm_filter
• Resolves the unterminated f-string syntax issue mentioned in the PR title

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The string joining operations are performed unconditionally, even when ids_fkb or ids_osm are empty lists. This creates unnecessary string operations that won't be used when the filters evaluate to "FALSE". Consider moving the join operations inside the ternary expressions or using lazy evaluation to avoid this overhead.

Example:

fkb_filter = "FALSE" if not ids_fkb else f"external_id IN ({', '.join(f\"'{v}'\" for v in ids_fkb)})"
osm_filter = "FALSE" if not ids_osm else f"external_id IN ({', '.join(f\"'{v}'\" for v in ids_osm)})"