Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires up infrastructure for running the building conflation pipeline in Kubernetes, aligns service imports with the src. package layout, and improves local configuration management.
Changes:
- Added a
k8s/job.yamlmanifest to run theosm-pipelinecontainer as a Kubernetes Job with secrets and image pull credentials. - Updated
fkb_serviceandopen_street_map_serviceto use fully qualifiedsrc.application.contracts/src.domain.enumsimports, adding missing interface imports. - Enhanced
docker-compose.ymlto load environment variables from a.envfile, extended.gitignoreto ignore.secrets, and introduced.github/workflows/events/pr.jsonfor PR event configuration.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/infra/infrastructure/services/open_street_map_service.py |
Fixes service and enum import paths to use the src. namespace and ensure all required interfaces are imported. |
src/infra/infrastructure/services/fkb_service.py |
Switches imports to src.-scoped modules and includes IBlobStorageService in the contracts used by FKBService. |
k8s/job.yaml |
Introduces a Kubernetes Job manifest to run the osm-pipeline image with production secrets and registry credentials. |
docker-compose.yml |
Configures the osm-pipeline service to load configuration from a .env file for local development. |
.gitignore |
Adds .secrets to ignored files and maintains ignoring of profiling JSON outputs. |
.github/workflows/events/pr.json |
Adds a JSON file describing pull request event conditions, presumably for use by GitHub Actions-related tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jathavaan I've opened a new pull request, #62, to work on those changes. Once the pull request is ready, I'll request review from you. |
jathavaan
added a commit
that referenced
this pull request
Jan 28, 2026
jathavaan
added a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces infrastructure improvements and environment configuration updates to support deployment and service integration. The most significant changes involve adding Kubernetes job configuration, updating Docker Compose to use environment variables, and correcting import paths in service files.
Deployment and Infrastructure:
k8s/job.yamlto define a batch job for the building conflation pipeline, including container setup, secrets, and restart policy.docker-compose.ymlto load environment variables from a.envfile for theosm-pipelineservice, improving local development and configuration management.Service Import Corrections:
src/infra/infrastructure/services/fkb_service.pyto use fully qualifiedsrc.prefixes and included missingIBlobStorageServicein the imports.src/infra/infrastructure/services/open_street_map_service.pyto usesrc.prefixes and included missingIBytesServicein the imports.Workflow Configuration:
.github/workflows/events/pr.jsonfile to specify pull request event conditions for GitHub Actions workflows.