Skip to content

#254 Increase ACI resources, split timeouts, drop default strategy#340

Merged
jathavaan merged 2 commits into
mainfrom
feature/254-increase-resources-for-aci-containers-and-postgresql
May 24, 2026
Merged

#254 Increase ACI resources, split timeouts, drop default strategy#340
jathavaan merged 2 commits into
mainfrom
feature/254-increase-resources-for-aci-containers-and-postgresql

Conversation

@jathavaan
Copy link
Copy Markdown
Collaborator

@jathavaan jathavaan commented May 24, 2026

Summary

  • Increase ACI container resources to 4 vCPU / 16 GB (matching Databricks worker class)
  • Split BENCHMARK_MAX_TIMED_WINDOW_SECONDS into per-iteration (75 min) and cumulative (450 min) hard timeouts
  • Handle Stopped/Terminated ACI container states in polling loop
  • Remove Sedona default-strategy benchmarks (infeasible: single iterations exceeded timeout, high failure rate, excessive cluster cost for no usable data)
  • Reduce RQ2 default-strategy worker levels from 5 to 3

Test plan

  • Verify Config.BENCHMARK_MAX_ITERATION_SECONDS = 4500 (75 min)
  • Verify Config.BENCHMARK_MAX_TIMED_WINDOW_SECONDS = 27000 (450 min = 6 × 75 min)
  • Confirm monitor.py per-iteration check uses MAX_ITERATION_SECONDS
  • Confirm monitor.py cumulative check uses MAX_TIMED_WINDOW_SECONDS
  • Confirm warmup per-iteration check uses MAX_ITERATION_SECONDS
  • Verify default-strategy entrypoints, runner cases, and benchmarks.yml entries removed
  • Run benchmark_runner.py --script-id <any-remaining-id> locally to verify dispatch still works

@jathavaan
#254 Split per-iteration and cumulative hard timeouts
99a5430 
Per-iteration timeout: 75 min (BENCHMARK_MAX_ITERATION_SECONDS).
Cumulative timeout: 6 × per-iteration = 450 min (BENCHMARK_MAX_TIMED_WINDOW_SECONDS).
Previously both checks shared one constant at 90 min.
Copilot AI review requested due to automatic review settings May 24, 2026 08:17
Copilot AI reviewed May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jathavaan jathavaan self-assigned this May 24, 2026
@jathavaan jathavaan merged commit 5d14fa8 into main May 24, 2026
@jathavaan jathavaan deleted the feature/254-increase-resources-for-aci-containers-and-postgresql branch May 24, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@jathavaan jathavaan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jathavaan