Conversation
Forward AZURE_UAMI_RESOURCE_ID to container environment variables so Config initialization no longer crashes on startup. Wrap container state polling in try/finally so failed containers are always cleaned up, preventing ACI core quota exhaustion across batches.
jathavaan
deleted the
bugfix/355-aci-containers-crash-on-startup-missing-azure_uami_resource_id-env-var-failed-containers-leak-quota
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to container lifecycle management and environment variable configuration in the
main.pyfile. The main changes ensure that container resources are cleaned up reliably and that all necessary environment variables are set when creating container instances.Container lifecycle management:
_run_container_benchmarkfunction now uses atry...finallyblock to guarantee that_delete_container_instanceis always called, ensuring container resources are cleaned up even if_check_container_statefails.Environment variable configuration:
_create_container_instancefunction now includes theAZURE_UAMI_RESOURCE_IDin the environment variables passed to the container, ensuring the container has access to this required configuration.