Skip to content

Githubaction#12

Merged
kasuken merged 1 commit into
mainfrom
githubaction
Sep 8, 2025
Merged

Githubaction#12
kasuken merged 1 commit into
mainfrom
githubaction

Conversation

@kasuken
Copy link
Copy Markdown
Owner

@kasuken kasuken commented Sep 8, 2025

  • Enhanced the GitHub Actions workflow to check out the base branch of the pull request for accurate builds.
  • Added steps to read package metadata and ensure the VSCE token is provided before publishing.
  • Updated the version in package.json from 0.7.1 to 0.7.2 to reflect the new changes.

…extension

- Enhanced the GitHub Actions workflow to check out the base branch of the pull request for accurate builds.
- Added steps to read package metadata and ensure the VSCE token is provided before publishing.
- Updated the version in package.json from 0.7.1 to 0.7.2 to reflect the new changes.
Copilot AI review requested due to automatic review settings September 8, 2025 15:13
@kasuken kasuken self-assigned this Sep 8, 2025
@kasuken kasuken added the enhancement New feature or request label Sep 8, 2025
@kasuken kasuken merged commit ad3669f into main Sep 8, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GitHub Actions workflow for publishing VS Code extensions by improving build accuracy and adding metadata handling. The changes ensure the workflow checks out the correct base branch for builds and includes proper token validation before publishing.

  • Updated package version from 0.7.1 to 0.7.2
  • Enhanced GitHub Actions workflow with base branch checkout and metadata extraction
  • Added VSCE token validation and GitHub release creation steps

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Version bump from 0.7.1 to 0.7.2
.github/workflows/publish-extension.yml Enhanced workflow with base branch checkout, metadata reading, token validation, and GitHub release creation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

run: |
echo "version=$(node -p \"require('./package.json').version\")" >> $GITHUB_OUTPUT
echo "name=$(node -p \"require('./package.json').name\")" >> $GITHUB_OUTPUT
echo "vsix=$(node -p \"const p=require('./package.json'); console.log(`${p.name}-${p.version}.vsix`)\")" >> $GITHUB_OUTPUT
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node command uses both -p (print) and console.log() which will output both the return value and the logged value. Use either node -p without console.log or node -e with console.log, but not both.

Suggested change
echo "vsix=$(node -p \"const p=require('./package.json'); console.log(`${p.name}-${p.version}.vsix`)\")" >> $GITHUB_OUTPUT
echo "vsix=$(node -p \"const p=require('./package.json'); `${p.name}-${p.version}.vsix`\")" >> $GITHUB_OUTPUT

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants