Skip to content

Update GitHub Actions workflow for VS Code extension publishing#15

Merged
kasuken merged 1 commit into
mainfrom
githubaction
Sep 8, 2025
Merged

Update GitHub Actions workflow for VS Code extension publishing#15
kasuken merged 1 commit into
mainfrom
githubaction

Conversation

@kasuken
Copy link
Copy Markdown
Owner

@kasuken kasuken commented Sep 8, 2025

Revise the GitHub Actions workflow to trigger on merged pull requests, enhance package metadata handling, and update the extension version to 0.7.2.

Copilot AI review requested due to automatic review settings September 8, 2025 17:20
@kasuken kasuken self-assigned this Sep 8, 2025
@kasuken kasuken added the bug Something isn't working label Sep 8, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the GitHub Actions workflow for VS Code extension publishing by modifying the package metadata handling script to use string concatenation instead of template literals.

  • Modified the package metadata reading script to use traditional string concatenation
  • Enhanced the workflow's compatibility with different Node.js environments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

id: get_meta
run: |
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, `version=${p.version}\n`); fs.appendFileSync(out, `name=${p.name}\n`); fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);"
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, 'version=' + p.version + '\n'); fs.appendFileSync(out, 'name=' + p.name + '\n'); fs.appendFileSync(out, 'vsix=' + p.name + '-' + p.version + '.vsix\n');"
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The inline Node.js script is difficult to read and maintain. Consider extracting this logic to a separate script file or using a multi-line YAML block with proper formatting for better readability.

Suggested change
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, 'version=' + p.version + '\n'); fs.appendFileSync(out, 'name=' + p.name + '\n'); fs.appendFileSync(out, 'vsix=' + p.name + '-' + p.version + '.vsix\n');"
node <<'EOF'
const fs = require('fs');
const p = require('./package.json');
const out = process.env.GITHUB_OUTPUT;
fs.appendFileSync(out, `version=${p.version}\n`);
fs.appendFileSync(out, `name=${p.name}\n`);
fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);
EOF

Copilot uses AI. Check for mistakes.
@kasuken kasuken merged commit fe938d3 into main Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants