Skip to content

Update CEPH health check#202

Merged
ialarmedalien merged 4 commits into
developfrom
develop-update-ceph-scripts
Jul 1, 2026
Merged

Update CEPH health check#202
ialarmedalien merged 4 commits into
developfrom
develop-update-ceph-scripts

Conversation

@mattldawson

Copy link
Copy Markdown
Collaborator

Description of PR purpose/changes

This PR updates the health check for CEPH using the Docker compose configuration. The previous check was only checking that the CEPH endpoint was reachable, but this led to a race condition which was causing intermittent action failures. It seems like the endpoint can become accessible before any OSDs have connected.

Copilot came up with this solution, but it looks reasonable to me, and it seems to be consistent with the errors in the action logs.

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
    Tests are not passing because of an unrelated problem with parsing NCBI assembly summary files.

Dev Checklist:

  • My submission follows the AI Covenant principles
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • N/A I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • N/A I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (except for already failing tests)
  • I have run Ruff format to format my code
  • I have run Ruff check and fixed any errors that it uncovered

Updating Version and Release Notes (if applicable)

N/A

Copilot AI review requested due to automatic review settings July 1, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ceph service healthcheck in docker-compose.yml to avoid intermittent CI failures by waiting for at least one OSD to be up before considering the RGW endpoint ready.

Changes:

  • Replace the prior “HTTP reachable” healthcheck with a two-part check: ceph osd stat + RGW HTTP probe.
  • Adjust healthcheck timing parameters (timeout/retries) to better tolerate startup delays.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yml
mattldawson and others added 2 commits July 1, 2026 12:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mattldawson mattldawson requested a review from ialarmedalien July 1, 2026 19:40
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.57%. Comparing base (44d07a0) to head (c01480f).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    68.38%   68.57%   +0.19%     
===========================================
  Files           72       73       +1     
  Lines         4432     4462      +30     
===========================================
+ Hits          3031     3060      +29     
- Misses        1401     1402       +1     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e41f4...c01480f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ialarmedalien ialarmedalien merged commit 301f583 into develop Jul 1, 2026
14 checks passed
@ialarmedalien ialarmedalien deleted the develop-update-ceph-scripts branch July 1, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants