Update CEPH health check#202
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ceph service healthcheck in docker-compose.yml to avoid intermittent CI failures by waiting for at least one OSD to be up before considering the RGW endpoint ready.
Changes:
- Replace the prior “HTTP reachable” healthcheck with a two-part check:
ceph osd stat+ RGW HTTP probe. - Adjust healthcheck timing parameters (timeout/retries) to better tolerate startup delays.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 68.38% 68.57% +0.19%
===========================================
Files 72 73 +1
Lines 4432 4462 +30
===========================================
+ Hits 3031 3060 +29
- Misses 1401 1402 +1 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
This PR updates the health check for CEPH using the Docker compose configuration. The previous check was only checking that the CEPH endpoint was reachable, but this led to a race condition which was causing intermittent action failures. It seems like the endpoint can become accessible before any OSDs have connected.
Copilot came up with this solution, but it looks reasonable to me, and it seems to be consistent with the errors in the action logs.
Testing Instructions
Tests are not passing because of an unrelated problem with parsing NCBI assembly summary files.
Dev Checklist:
formatto format my codecheckand fixed any errors that it uncoveredUpdating Version and Release Notes (if applicable)
N/A