eips: finalize native-ETH A2A escrow as a Standards-Track ERC (#50)#128
Merged
Conversation
Bring eips/draft-native-eth-a2a-escrow.md to editor-ready ERC quality and add the two submission-support docs. Draft: - ERC-165 interface id VERIFIED = 0x5c3738e9. Reproduced the six selectors from keccak256 of the canonical signatures and showed the running XOR in the spec; matches the pinned value. cast-sig recipe included. - New "ERC-165 interface identifier" subsection: states explicitly that selectors depend only on argument types (return shape, payable/view, address-vs-address-payable are irrelevant) — this is why the reference contract's bool/struct return forms keep the same id. - New "Errors" subsection in §Specification: normative revert table per function + RECOMMENDED custom-error set. Closes the missing-errors gap. - Reference Implementation section corrected to the real repo layout (test/AgentEscrow.t.sol + contracts/test/AgentEscrowOracle.t.sol + contracts/mocks/MockOracleAggregator.sol), describes the contract as a superset of IAgentEscrow, and flags two honest conformance gaps: (1) reference contract does not yet expose ERC-165 supportsInterface, (2) reference enum has extra members. Neither affects the interface id. - Test Cases table replaced with the actual Foundry test names (the prior table listed tests that do not exist, incl. a fictional supportsInterface test). - Frontmatter: eip/discussions-to placeholders annotated with an editor note explaining they are assigned during the ethereum/EIPs PR. Added: - eips/magicians-post-draft.md — forum pitch + 6 open questions. - eips/SUBMISSION-CHECKLIST.md — fork, eip-XXXX naming, editor number assignment, eipw lint gates, what an editor will/won't gate on. Hardening from stale branch eip/native-eth-a2a-escrow (commit 63c7377) was already folded into main (drafts were byte-identical); this commit builds on it and reconciles the spec with the actual reference contract. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Merged — thank you, @Pattermesh. Your first kcolbchain contribution is in. 🎉 A few things that unlocked with this merge:
If you want to stay in the loop on what we're shipping: https://kcolbchain.com/ROADMAP.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizes the AgentEscrow EIP to Standards-Track ERC quality (addresses #50).
0x5c3738e9verified by selector-XOR.🤖 Generated with Claude Code