fix(deps): add missing go.sum entry for luxfi/mdns + wire CI#1
Open
RTHYMS wants to merge 1 commit into
Open
Conversation
go test ./... failed on main with: node.go:18:2: missing go.sum entry for module providing package github.com/luxfi/mdns (imported by github.com/luxfi/zap) \`go mod tidy\` adds the two missing checksum lines. After: main and mcp packages pass. The break suggests the last push to main didn't run \`go test\` locally — wiring CI prevents that recurring. - Add .github/workflows/ci.yml — go test -race across Go 1.22 and 1.23 - Add .github/SECURITY.md - Add CI badge to README
|
Welcome to kcolbchain, @RTHYMS — glad you're here. 🌱 Here's what happens from this PR:
While you wait:
What happens after your first merge
Thanks for writing the code. We're building this to last. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`go test ./...` against main fails to build, not run:
```
node.go:18:2: missing go.sum entry for module providing package
github.com/luxfi/mdns (imported by github.com/luxfi/zap); to add:
go get github.com/luxfi/zap
FAIL github.com/luxfi/zap [setup failed]
FAIL github.com/luxfi/zap/bench [setup failed]
FAIL github.com/luxfi/zap/examples/agents [setup failed]
FAIL github.com/luxfi/zap/examples/mcp-bridge [setup failed]
FAIL github.com/luxfi/zap/mcp [setup failed]
```
Fix
`go mod tidy` adds 2 lines (the `luxfi/mdns` h1 + go.mod checksum). After:
```
ok github.com/luxfi/zap 3.819s
ok github.com/luxfi/zap/mcp 0.692s
```
(3 examples / bench packages have no test files — `?`, not failures.)
The `go.sum` gap suggests whoever pushed last didn't run `go test ./...`. This PR also wires CI so that recurring is harder.
Drive-by