build(deps-dev): bump @astrojs/sitemap from 3.2.1 to 3.7.3 in /site#17
build(deps-dev): bump @astrojs/sitemap from 3.2.1 to 3.7.3 in /site#17dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@astrojs/sitemap](https://github.com/withastro/astro/tree/HEAD/packages/integrations/sitemap) from 3.2.1 to 3.7.3. - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/integrations/sitemap/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/@astrojs/sitemap@3.7.3/packages/integrations/sitemap) --- updated-dependencies: - dependency-name: "@astrojs/sitemap" dependency-version: 3.7.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by minimax-m3 · Input: 31.2K · Output: 3K · Cached: 170.4K |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 359e17193b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "devDependencies": { | ||
| "@astrojs/sitemap": "~3.2.0" | ||
| "@astrojs/sitemap": "~3.7.3" |
There was a problem hiding this comment.
With this change /site still depends on astro ^4.16.18 and site/astro.config.mjs registers the sitemap integration, so installing ~3.7.3 puts this build on the known incompatible combination of Astro 4 + @astrojs/sitemap 3.7.x. The 3.7.x integration relies on routes from astro:routes:resolved, which Astro 4 does not provide; upstream withastro/astro#15894 reproduces Cannot read properties of undefined (reading 'reduce') during astro build on Astro 4.16.19 after upgrading sitemap from 3.6.0 to 3.7.1. This will break /site builds until Astro is upgraded or sitemap is kept at the 3.6.x line.
Useful? React with 👍 / 👎.
| }, | ||
| "devDependencies": { | ||
| "@astrojs/sitemap": "~3.2.0" | ||
| "@astrojs/sitemap": "~3.7.3" |
There was a problem hiding this comment.
site/bun.lock was not updated, so its importer still records @astrojs/sitemap as ~3.2.0 and locks @astrojs/sitemap@3.2.0, while the Pages workflow builds the landing site with cd site && bun install --frozen-lockfile (.github/workflows/pages.yml). Because Bun documents --frozen-lockfile as disallowing lockfile changes, this package.json-only bump leaves CI unable to reconcile the new ~3.7.3 requirement during the deploy build; commit the regenerated site/bun.lock alongside the manifest change.
Useful? React with 👍 / 👎.
Bumps @astrojs/sitemap from 3.2.1 to 3.7.3.
Release notes
Sourced from @astrojs/sitemap's releases.
Changelog
Sourced from @astrojs/sitemap's changelog.
... (truncated)
Commits
1e49163[ci] release (#16832)783c4a6Stamp sitemap index entries with per-file lastmod (#16837)5a8cd09refactor: update tsconfig to use TypeScript project references (#16505)5c543c5refactor(astro): add internal entry points for test (#16473)f7566b8refactor: unify test setup (#16445)ba2dbf1refactor(astro): correct Fixture type signatures in test-utils (#16380)245f300refactor: migrate sitemap tests to typescript (#16353)88fcc98fix integrations links across docs (#16098)4a6ff2a[ci] release (#16020)28079e9[ci] formatMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@astrojs/sitemapsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)