build(deps): bump react from 18.3.1 to 19.2.7 in /site#20
build(deps): bump react from 18.3.1 to 19.2.7 in /site#20dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 18.3.1 to 19.2.7. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.7/packages/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.7 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| "astro-icon": "^1.1.5", | ||
| "lucide-react": "^1.17.0", | ||
| "react": "^18.3.1", | ||
| "react": "^19.2.7", |
There was a problem hiding this comment.
CRITICAL: react is being bumped to ^19.2.7 but react-dom is left at ^18.3.1 (line 20). React 19 and React DOM 18 are not a valid pair — they share a peer-dependency contract and must be upgraded together. Running bun install/npm install against this PR will produce an ERESOLVE peer-dependency conflict (react-dom@18 declares react@^18.0.0; react@19 declares react-dom@^19.0.0). Even if the install is forced through, mixed majors will fail at render time with hooks/context errors. Ask Dependabot to also bump react-dom to ^19.2.7 (and any matching @types/react / @types/react-dom if present).
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by minimax-m3 · Input: 32.5K · Output: 2K · Cached: 140K |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4de2ca2e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "astro-icon": "^1.1.5", | ||
| "lucide-react": "^1.17.0", | ||
| "react": "^18.3.1", | ||
| "react": "^19.2.7", |
There was a problem hiding this comment.
This manifest bump is not accompanied by site/bun.lock: the lockfile still lists the workspace dependency as react: ^18.3.1 and locks react@18.3.1. The Pages workflow builds the landing site with cd site && bun install --frozen-lockfile && bun run build (.github/workflows/pages.yml:198), and bun install --help documents --frozen-lockfile as disallowing lockfile changes, so CI cannot apply or test the requested React 19.2.7 upgrade. Please regenerate and commit site/bun.lock with this dependency change.
Useful? React with 👍 / 👎.
| "astro-icon": "^1.1.5", | ||
| "lucide-react": "^1.17.0", | ||
| "react": "^18.3.1", | ||
| "react": "^19.2.7", |
There was a problem hiding this comment.
This upgrades only react to 19.x while leaving react-dom at ^18.3.1; the currently locked react-dom@18.3.1 declares a peer on react: ^18.3.1, and Astro's React integration uses ReactDOM for rendering/hydration. After the lockfile is refreshed this will resolve an unsupported React 19 / ReactDOM 18 pair, risking peer-resolution failures or runtime hydration/rendering issues. Please bump react-dom to the matching React 19 version in the same change.
Useful? React with 👍 / 👎.
Bumps react from 18.3.1 to 19.2.7.
Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
6117d7cVersion 19.2.7 (#36591)eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.15667a41Bump next prerelease version numbers (#34639)8bb7241Bump useEffectEvent to Canary (#34610)e3c9656Ensure Performance Track are Clamped and Don't overlap (#34509)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)