This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Added screenshots for python3 getting_started.py test step#16
Open
mwherman2000 wants to merge 60 commits intokdenhartog:masterfrom
Open
Added screenshots for python3 getting_started.py test step#16mwherman2000 wants to merge 60 commits intokdenhartog:masterfrom
mwherman2000 wants to merge 60 commits intokdenhartog:masterfrom
Conversation
Owner
|
I'd like to remove all of the images that aren't currently being used to keep the size of this repository smaller. Did you have a plan to use these? |
Author
|
It's a bit TBD for the unused images. As part of trying to figure out the
I'll likely end up have to regenerate the unused images ...so let me delete them for now. |
added 17 commits
January 21, 2019 11:27
Owner
|
I've gotten a chance to look through this work. I think this is headed in the right direction. It looks like there's a few things that still have TODOs in there. Once you've gotten to a point where you feel like it's ready or you'd like another review can you ping me in the comments here or on rocketchat? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've only tested this against the Windows 10 setup steps (previous section of the README.md).
The updated instructions and screen shots assume the python folder is here:
/indy-dev/python. Is this the same on Mac and Linux?