Merged
Conversation
…umns - test_browsing: app startup, cursor movement, jump top/bottom, page up/down, resize - test_filtering: filter reduces rows, clear restores, search highlights, next/prev, escape closes - test_bookmarks_columns: toggle bookmark, bookmarks panel, column selector, column visibility, initial columns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- test_resize: incremental shrink/expand, shrink-then-restore, cursor validity - test_bookmarks_columns: bookmark navigation via panel selection, multi-bookmark navigation, panel close on escape - test_expressions: compute new column, use in filter, chain as input for further expressions, expression box close - Moved resize test out of test_browsing into dedicated test_resize file Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add assertions that computed columns appear in table._dt.columns and table._widths after expression evaluation - Remove unused imports and variables flagged by ruff Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 8 snapshot tests covering initial view, cursor movement, filtering, search results, column selector, column hiding, narrow terminal, and row detail. Fix mypy type errors in expression_box.py (None guard for event.item.name) and browser.py (use empty string instead of None for pending_action reactive). Add pytest-textual-snapshot dev dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Snapshot tests depend on environment-specific SVG rendering and fail in CI. Mark them with a `snapshot` pytest marker and exclude from `make test`. Add separate `make test-snapshot` target for local use. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When snapshot tests fail in CI, the snapshot_report.html (visual diff) is uploaded as a downloadable artifact and a note is added to the workflow summary. Uses continue-on-error to ensure artifacts are captured before failing the job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The snapshot baselines are generated locally and compared in CI. Pin syrupy to 4.x to ensure both environments use the same snapshot storage format and path conventions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FilterBox now reads DT_BROWSER_HISTORY_FILE to override the default history path. A new autouse conftest fixture sets this to a temp file per test, preventing history from leaking across tests when execution order varies. Re-recorded snapshot for test_snap_filter_applied. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.