Merged
Conversation
Adds a new 'w' keybinding to toggle auto column width mode, which sizes columns based only on visible rows instead of the full dataset. Widths update dynamically as rows scroll in/out of view or the terminal is resized. Only recomputes when the visible row range actually changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
This breaks when all the columns currently displayed have null/no values. The error is: |
…dth mode When auto-width recalculates narrower widths (e.g. all-null columns), the visible column set can shift so cursor_col_idx falls out of bounds. Clamp the index to prevent the crash. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Fixed! The issue was that when auto-width recalculates narrower widths (e.g. for all-null visible columns), the set of Fix: Added a clamp on Test: Added All 47 tests pass, |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
w) that sizes columns based only on the currently visible rows instead of the full dataset(scroll_y, dt_height)actually changes — cursor movement within the same visible area skips recomputationTest plan
make checkpasses (format, lint, typecheck)🤖 Generated with Claude Code