fix(dmg): preserve image quality and @2x Retina in background padding#164
Merged
kdroidFilter merged 1 commit intomainfrom Mar 28, 2026
Merged
fix(dmg): preserve image quality and @2x Retina in background padding#164kdroidFilter merged 1 commit intomainfrom
kdroidFilter merged 1 commit intomainfrom
Conversation
The previous padding implementation used Java ImageIO with issues: - Renamed output to background-padded.png, breaking electron-builder's @2x auto-detection (transformBackgroundFileIfNeed) - Did not pad @2x Retina variants, causing blurry backgrounds - Used original image type which could produce black padding instead of transparent when the source lacked an alpha channel Fix by preserving the original filename, explicitly handling @2x variants with 2x pixel padding, and always using TYPE_INT_ARGB with AlphaComposite.Clear for guaranteed transparent padding. Add 14 unit tests covering dimensions, transparency, @2x handling, idempotency, and edge cases. Closes #163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the DMG background image rendering issue introduced in v1.5.0 (#26 fix).
The previous
padDmgBackgroundForTitleBarimplementation had three bugs:background-padded.png, breaking electron-builder's@2xauto-detection (transformBackgroundFileIfNeedlooks for<name>@2x.<ext>next to the source)@2xRetina variants, so only the 1x image was padded — Retina displays showed blurry/unpadded backgroundsTYPE_3BYTE_BGR)Changes
@2xvariants@2xfiles with2× MACOS_DMG_TITLE_BAR_HEIGHTpixels (56px for Retina)TYPE_INT_ARGB+AlphaComposite.Clearfor guaranteed transparent paddingCloses #163
Test plan
DmgBackgroundPaddingTest)