Draft
Conversation
Collaborator
Author
|
Okay here's my proposed API @keaz. Basically combining I'm still going to sit on this for a while longer and test some more but feel free to share your thoughts on this design. |
Collaborator
Author
|
Alternatively we could consider some kind of builder api. The streaming search is starting to have quite a bit of parameters. |
keaz
reviewed
Mar 6, 2026
| Ok(Some(result_entry)) | ||
| } | ||
| Some(ServerSideSortResponse { sort_result, .. }) => { | ||
| panic!( |
Owner
There was a problem hiding this comment.
Is it ok to Panic, shall we return a error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for the LDAP Server Side Sort extension defined in RFC 2891.
This is done by implementing a couple new controls, a corresponding adapter, and then exposing it in the public API. The API part requires still some thought. Open to suggestions!
I might try to upstream the low level bits to
ldap3crate at some point too, but lets just start here. This will be an invisible change if it does happen in the future.fixes: #52