This repository was archived by the owner on May 26, 2025. It is now read-only.
update to PHP 8.x#1
Closed
odinuv wants to merge 2 commits into
Closed
Conversation
|
Comment on lines
+7
to
+17
| ci-tests: | ||
| build: | ||
| context: . | ||
| target: dev | ||
| image: toxiproxy-php-client | ||
| command: ["composer", "test"] | ||
| environment: | ||
| TOXIPROXY_HOST: toxiproxy | ||
| depends_on: | ||
| toxiproxy: | ||
| condition: service_started |
There was a problem hiding this comment.
Jak to vyvyjis lokalne? Je to libka, tak tohle stalo za to uz uplne otocit, kdyz se to tu dela na cerstvo (jak to delame v platform libs):
- zrusit
ci-tests - zavest
devs mountovanymi zdrojaky Dockerfilebez zdrojaku/composer.*- v CI poustest `docker comose run --rm dev bash -c "composer install && composer test"
Comment on lines
+146
to
+147
| string $type, | ||
| string $stream, |
There was a problem hiding this comment.
Tohle by asi mely byt ty novy enumy
Member
Author
|
No to je právě to, co nevím - jestli se snažit to mergnout do originálu, nebo rovnou udělat hard fork - podle toho bych pak řešil ten zbytek. Osobně bych radši udělal hard fork - na originál 8let nikdo nešáhl, tak pochybuju, že by se to změnilo |
Naprosty souhlas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.