Skip to content

test(e2e): accept 422 alongside 404 for unfetchable page #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilya-bogin-keenable wants to merge 2 commits into from
+6 −1
Closed

test(e2e): accept 422 alongside 404 for unfetchable page #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e34b725
test(e2e): accept 422 alongside 404 for unfetchable page
Bryunyon Jun 30, 2026
d15dfc5
test(e2e): correct the dead-page comment on when 422 shows up
ilya-bogin-keenable Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/e2e/test_fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ def test_dead_page(kn):
res = kn("fetch", "https://example.com/nonexistent-xyz-12345")
assert res.code == 1
data = res.yaml()
assert data["error"] == "Not found"
# The backend rejects an unfetchable page with either a 404 ("Not found")
# or a 422 ("Unprocessable entity"); both are valid "this page can't be
# fetched" outcomes. As of 2026-07-25 it always answers 422, even for a
# domain that doesn't resolve, so this can't assert which one — see the
# open backend bug on 422 being a catch-all.
assert data["error"] in ("Not found", "Unprocessable entity")


def test_invalid_key_on_fetch(kn):
Expand Down
Loading