Use Background Portal if available for autostart#13482
Draft
hifi wants to merge 1 commit into
Draft
Conversation
Refactored to use dbus code generator with the real portal XML spec.
Contributor
Author
|
This didn't really work as-is on either KDE or GNOME. Both created an autostart entry without the Exec key. We need to set the command manually which somewhat defeats the point of using the portal in the first place. The portal spec says you can leave the command out and it'll use the one in the desktop file but that wasn't the case in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored to use dbus code generator with the real portal XML spec.
This makes auto-start work "natively" on Wayland desktops like Plasma that provides the portal to non-sandboxed applications as well and avoids us from creating a custom entry.
Testing strategy
TBD
Type of change