feat: add NVIDIA GPU usage and temperature command#49
Open
kevinderome wants to merge 2 commits intokefaslungu:mainfrom
Open
feat: add NVIDIA GPU usage and temperature command#49kevinderome wants to merge 2 commits intokefaslungu:mainfrom
kevinderome wants to merge 2 commits intokefaslungu:mainfrom
Conversation
Add a command that reports NVIDIA GPU usage and temperature via nvidia-smi with lazy path discovery on first request. The implementation is intentionally NVIDIA-only for now because AMD tooling does not expose a single stable path on Windows. Made-with: Cursor
josephsl
requested changes
Apr 3, 2026
Collaborator
josephsl
left a comment
There was a problem hiding this comment.
Overall, the idea looks promising.
A few things:
- Please add translator comments to messages, especially GPU messages. Some translators many not know what "NVIDIA GPU" is unless they know somehting aobut a video card. You can look at othe parts of the add-on source code for example translator comments.
- I recommend phrasing the message to be as GPU neutral as much as possible e.g. "No NVIDIA GPU found" -> "No GPU temperature information".
- Does this feature cover Intel built-in GPU such as Intel HD Graphics or Xe?
- NVDA+Shift+number row 9 is taken up by several add-ons. This can cause conflicts if an add-on that uses this key combo is started AFTER Resource Monitor, meaning anyone with an NVIDIA GPU won't be able to learn video card temperature.
Thanks.
Collaborator
|
Hi, Ping: please address review comments by April 13, 2026 at 23:59 UTC. If nothing is done by then, this pull request will be closed. Thanks. |
- Change shortcut to NVDA+Shift+0 and NVDA+Shift+Numpad0 instead of 9 to reduce clashes with other add-ons. - Rephrase user-visible strings in a vendor-neutral way. - Add gettext translator comments for GPU messages and input help text.
Author
|
Hi @josephsl,
Thanks again for the review. |
josephsl
requested changes
Apr 11, 2026
Collaborator
josephsl
left a comment
There was a problem hiding this comment.
Hi,
Thanks for responding to the review comments.
Two suggestions:
- NVDA+Shift+number row 0/Numpad 0 are taken up by other add-ons too. You are not alone in running into the problem of running out of keyboard combos, and to solve this, I think it would be best to leave it unassigned.
- I think it would be best to separate NVIDIA specific routines from overall GPU info gatherer. This allows separate routines to be invoked for different vendors - kind of how the overall GPU info gatherer and messages serve as a "hardware abstraction layer". Separate vendor-specific routines from vendor neutral messages also allows you and others to extend the routine to cover Intel, AMD, and Qualcomm (on ARM64) video cards in the future.
Thanks for the hard work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia-sminvidia-smipath lazily on first request to avoid startup overhead for users who do not use this commandTest plan
sconsNVDA+Shift+9nvidia-smiand announces GPU usage/temperature