(WIP) feature: Drain nodes prior to termination when using RollingUpgrade strategy#259
Open
eytan-avisror wants to merge 19 commits intokeikoproj:masterfrom
Open
(WIP) feature: Drain nodes prior to termination when using RollingUpgrade strategy#259eytan-avisror wants to merge 19 commits intokeikoproj:masterfrom
eytan-avisror wants to merge 19 commits intokeikoproj:masterfrom
Conversation
added 3 commits
February 16, 2021 17:05
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
backjo
reviewed
Feb 17, 2021
added 8 commits
February 17, 2021 15:40
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
===========================================
+ Coverage 51.08% 85.37% +34.28%
===========================================
Files 33 18 -15
Lines 4504 2345 -2159
===========================================
- Hits 2301 2002 -299
+ Misses 2062 237 -1825
+ Partials 141 106 -35
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds to #197
This feature adds a capability to do draining in parallel via kubectl as a library (not shelling out), prior to termination of instances.
This makes the rollingUpgrade strategy much more usable.
Implementation adds a sync.Map of
namespacedName:sync.WaitGroupat the controller level in order to keep track of draining nodes.The drain is initiated and then the controller will re-queue until operation has completed or errors out.
Also refactored to move the rollingUpgrade logic from kubeprovider into the eks package.
TBD: