Replace /review with self-review in agent prompts#638
Closed
kelos-bot[bot] wants to merge 1 commit intomainfrom
Closed
Replace /review with self-review in agent prompts#638kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Maintainer feedback on PR #586 confirmed that commenting "/review" on PRs does not work. Replace all /review references with self-review instructions that use `git diff origin/main...HEAD` to read the full diff. Also add `--force-with-lease` guidance for push after rebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
needs-triage
needs-kind
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Collaborator
|
I think we don't need to do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Replaces non-functional
/reviewcomment instructions with self-review viagit diffin two TaskSpawner prompt templates:Also adds
--force-with-leaseguidance for push steps after rebase.Which issue(s) this PR is related to:
N/A — driven by recurring maintainer feedback on agent-generated PRs.
Special notes for your reviewer:
Evidence from PR reviews:
/reviewdoesn't work — PR Handle label commands across issue, PR, and review surfaces #586: maintainer @gjkim42 commented: "commenting '/review' doesn't work at all. you have to review your code yourself." Agents were posting/reviewas PR comments expecting automated review, but this has no effect.--force-with-leaseneeded after rebase — PR Add pre-push verification, diff checks, and commit squashing conventions #619 review: cubic-dev-ai noted that regulargit pushis rejected after squashing/rebasing. Agents need explicit guidance to use--force-with-lease.The self-review instructions tell agents to run
git diff origin/main...HEAD(orupstream/main...HEADwhen applicable) and carefully read the full diff, checking for correctness, style, missing tests, and alignment with requirements.Does this PR introduce a user-facing change?
Summary by cubic
Replaced the non-functional "/review" step with explicit self-review using
git diff origin/main...HEAD(orupstream/main...HEAD) inself-development/kelos-workers.yamlandself-development/kelos-pr-responder.yaml, and added guidance to usegit push --force-with-leaseafter a rebase. This removes ineffective PR comments and avoids push failures, improving PR quality and reliability.Written for commit f505b8c. Summary will update on new commits.