Skip to content

Update agent config based on PR review feedback#729

Open
kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-config-update-20260317-1800
Open

Update agent config based on PR review feedback#729
kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-config-update-20260317-1800

Conversation

@kelos-bot
Copy link

@kelos-bot kelos-bot bot commented Mar 17, 2026

/kind cleanup

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates agent configuration files based on actionable patterns identified from recent PR review feedback. Three conventions are added:

  1. Always update self-development configs and examples when adding new API fields/features — Reviewers repeatedly asked agents to update self-development/ and examples/ when introducing new fields (PR Add spec.on as alias for spec.when on TaskSpawner #720, PR Add per-source pollInterval override #719).
  2. Do not hard-code future API version names in deprecation notices — Reviewer noted that the next API version is not yet determined, so agents should not write things like "will be removed in v1alpha2" (PR Add spec.on as alias for spec.when on TaskSpawner #720).
  3. /kind <label> in PR body auto-applies the label — Reviewer pointed out that including /kind something in the body already handles label application, making --label kind/... flags redundant (PR Remove redundant git checkout from pr-responder setup #705). Fixed the kelos-image-update prompt which was using the redundant flag.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Evidence from PR reviews:

Files changed:

  • AGENTS.md (+ CLAUDE.md symlink) — Added project-level conventions for API deprecation notices, new field completeness, and /kind label behavior
  • self-development/agentconfig.yaml — Added the same conventions to the shared AgentConfig
  • self-development/kelos-workers.yaml — Added API conventions to the workers agent config
  • self-development/kelos-image-update.yaml — Removed redundant --label kind/feature from gh pr create

Does this PR introduce a user-facing change?

NONE

Summary by cubic

Aligns agent configs and docs with recent review feedback. Adds clear conventions for new API fields, deprecation notices, and PR labeling, and removes a redundant label flag.

  • Refactors
    • AGENTS.md: add rules for deprecation notices (no hard-coded future versions) and updating self-development/ + examples/; note that /kind <label> auto-applies labels.
    • self-development/agentconfig.yaml and self-development/kelos-workers.yaml: mirror the new conventions.
    • self-development/kelos-image-update.yaml: remove redundant --label kind/feature from gh pr create.

Written for commit 4ec2a56. Summary will update on new commits.

Add conventions learned from recent PR reviews:
- Always update self-development configs and examples when adding new API fields
- Do not hard-code future API version names in deprecation notices
- /kind label in PR body auto-applies the label, no need for --label kind/... flag

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant