Update agent config based on PR review feedback#729
Open
kelos-bot[bot] wants to merge 1 commit intomainfrom
Open
Update agent config based on PR review feedback#729kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Add conventions learned from recent PR reviews: - Always update self-development configs and examples when adding new API fields - Do not hard-code future API version names in deprecation notices - /kind label in PR body auto-applies the label, no need for --label kind/... flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates agent configuration files based on actionable patterns identified from recent PR review feedback. Three conventions are added:
self-development/andexamples/when introducing new fields (PR Add spec.on as alias for spec.when on TaskSpawner #720, PR Add per-source pollInterval override #719)./kind <label>in PR body auto-applies the label — Reviewer pointed out that including/kind somethingin the body already handles label application, making--label kind/...flags redundant (PR Remove redundant git checkout from pr-responder setup #705). Fixed thekelos-image-updateprompt which was using the redundant flag.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Evidence from PR reviews:
Files changed:
AGENTS.md(+CLAUDE.mdsymlink) — Added project-level conventions for API deprecation notices, new field completeness, and/kindlabel behaviorself-development/agentconfig.yaml— Added the same conventions to the shared AgentConfigself-development/kelos-workers.yaml— Added API conventions to the workers agent configself-development/kelos-image-update.yaml— Removed redundant--label kind/featurefromgh pr createDoes this PR introduce a user-facing change?
Summary by cubic
Aligns agent configs and docs with recent review feedback. Adds clear conventions for new API fields, deprecation notices, and PR labeling, and removes a redundant label flag.
self-development/+examples/; note that/kind <label>auto-applies labels.--label kind/featurefromgh pr create.Written for commit 4ec2a56. Summary will update on new commits.