Update agent config: address review feedback from recent PRs#748
Merged
Update agent config: address review feedback from recent PRs#748
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates agent configuration based on review feedback from recent PRs:
Add
KELOS_UPSTREAM_REPOto CI check commands (kelos-pr-responder)gh pr checkscan target the wrong repo in upstream/fork workflows without--repo "$KELOS_UPSTREAM_REPO"Require
make verifyandmake testin re-review loops (kelos-pr-responder, kelos-workers)Add Kubernetes
resource.Quantitycomparison convention (AGENTS.md, agentconfig.yaml)reflect.DeepEqualmisdetected drift for equivalentresource.Quantityvalues because the struct has internal fields that differ for semantically identical quantities (e.g.,1000mvs1CPU). Adding this as a project convention to prevent recurrence.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
All review feedback has been addressed:
agentconfig.yamlandAGENTS.mdper reviewer request (to be handled separately)Does this PR introduce a user-facing change?