Skip to content

Update agent config: address review feedback from recent PRs#748

Merged
gjkim42 merged 1 commit intomainfrom
kelos-config-update-20260319-1800
Mar 22, 2026
Merged

Update agent config: address review feedback from recent PRs#748
gjkim42 merged 1 commit intomainfrom
kelos-config-update-20260319-1800

Conversation

@kelos-bot
Copy link

@kelos-bot kelos-bot bot commented Mar 19, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates agent configuration based on review feedback from recent PRs:

  1. Add KELOS_UPSTREAM_REPO to CI check commands (kelos-pr-responder)

  2. Require make verify and make test in re-review loops (kelos-pr-responder, kelos-workers)

  3. Add Kubernetes resource.Quantity comparison convention (AGENTS.md, agentconfig.yaml)

    • Motivated by: PR Add spawner container resource requirements flags #737 review — reflect.DeepEqual misdetected drift for equivalent resource.Quantity values because the struct has internal fields that differ for semantically identical quantities (e.g., 1000m vs 1 CPU). Adding this as a project convention to prevent recurrence.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

All review feedback has been addressed:

  • Removed "API changes require config updates" convention from both agentconfig.yaml and AGENTS.md per reviewer request (to be handled separately)
  • Commits squashed into a single commit

Does this PR introduce a user-facing change?

NONE

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant