test(parser): assert registry completeness in both directions#691
Open
mjacobs wants to merge 1 commit into
Open
test(parser): assert registry completeness in both directions#691mjacobs wants to merge 1 commit into
mjacobs wants to merge 1 commit into
Conversation
TestRegistryCompleteness only checked that each listed agent was registered, so agents added to Registry without a matching allTypes entry passed silently. Five had already drifted out: Antigravity, AntigravityCLI, Iflow, WorkBuddy, and Zencoder. Add the missing agents and assert allTypes and Registry match exactly in both directions, plus reject duplicate entries on either side, so a new AgentDef cannot bypass the completeness check.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRegistryCompletenessonly asserted that each agent listed in itshand-maintained
allTypesslice was present inRegistry. The reverse wasnever checked, so an agent added to
Registrywithout a matchingallTypesentry passed silently. Five agents had already drifted out this way:
Antigravity, AntigravityCLI, Iflow, WorkBuddy, and Zencoder.
This adds the five missing agents and makes the check bidirectional:
allTypesand
Registrymust now contain exactly the same set ofAgentTypes, andduplicate entries on either side are rejected. A new
AgentDefcan no longerbypass the completeness check, and the failure message names the fix (add the
type to
allTypes).The list stays hand-maintained on purpose: it keeps adding an agent a
deliberate, reviewed act rather than something derived reflectively from
Registry, which would make the assertion tautological. The change is confinedto
internal/parser/types_test.go; no production code is affected.