[codex] Fix Windows daemon console probe hang#20
Merged
Conversation
roborev: Combined Review (
|
b99afa2 to
1deaffe
Compare
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartDetachedback toDETACHED_PROCESSso daemon startup does not exposeCONIN$to terminal probesCREATE_NO_WINDOWto non-interactivegit/cmdsubprocess creation, including safe-directory config probesTerminalPrompt=trueRoot Cause
PR #14 moved detached daemons from
DETACHED_PROCESStoCREATE_NO_WINDOWto prevent visible console flashing from console-subsystem descendants. That gives the daemon a hidden live console, so libraries that probe terminal state can openCONIN$and block waiting for terminal replies during startup.This keeps daemons console-less and applies hidden-window behavior at the known non-interactive git spawn sites instead.
Fixes #19.
Validation
go test ./...go vet ./...