Skip to content

[codex] Fix Windows daemon console probe hang#20

Merged
mariusvniekerk merged 1 commit into
mainfrom
fix-daemon-startdetached-windows-tty
Jun 12, 2026
Merged

[codex] Fix Windows daemon console probe hang#20
mariusvniekerk merged 1 commit into
mainfrom
fix-daemon-startdetached-windows-tty

Conversation

@mariusvniekerk

Copy link
Copy Markdown
Contributor

Summary

  • switch Windows daemon StartDetached back to DETACHED_PROCESS so daemon startup does not expose CONIN$ to terminal probes
  • move CREATE_NO_WINDOW to non-interactive git/cmd subprocess creation, including safe-directory config probes
  • add Windows regression tests for daemon console input exposure and git subprocess window hiding while preserving TerminalPrompt=true

Root Cause

PR #14 moved detached daemons from DETACHED_PROCESS to CREATE_NO_WINDOW to prevent visible console flashing from console-subsystem descendants. That gives the daemon a hidden live console, so libraries that probe terminal state can open CONIN$ and block waiting for terminal replies during startup.

This keeps daemons console-less and applies hidden-window behavior at the known non-interactive git spawn sites instead.

Fixes #19.

Validation

  • go test ./...
  • go vet ./...

@roborev-ci

roborev-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

roborev: Combined Review (b99afa2)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 4m2s), codex_security (codex/security, done, 32s) | Total: 4m34s

@mariusvniekerk mariusvniekerk marked this pull request as ready for review June 12, 2026 12:20
@mariusvniekerk mariusvniekerk force-pushed the fix-daemon-startdetached-windows-tty branch from b99afa2 to 1deaffe Compare June 12, 2026 13:50
@roborev-ci

roborev-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

roborev: Combined Review (1deaffe)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 4m2s), codex_security (codex/security, done, 41s) | Total: 4m43s

@mariusvniekerk mariusvniekerk merged commit a81635f into main Jun 12, 2026
8 checks passed
@mariusvniekerk mariusvniekerk deleted the fix-daemon-startdetached-windows-tty branch June 12, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

daemon: StartDetached (Windows) hangs at startup when the child process imports charm/lipgloss

1 participant