[codex] Hide git runner console windows on Windows#21
Merged
Conversation
roborev: Combined Review (
|
mariusvniekerk
force-pushed
the
codex/gitcmd-windows-no-window
branch
from
b35651d to
170d0d5
Compare
roborev: Combined Review (
|
The safe.directory config probes in readSafeDirectories still built their git processes with exec.CommandContext directly, bypassing the prepareGitCommand hook this branch adds. On Windows that meant the probe processes could each flash a visible console window before the main git command ran — the exact behavior the branch exists to suppress. Flagged by roborev review of 170d0d5. Validation: go build ./..., go test ./git/cmd, GOOS=windows go build ./git/..., go vet ./git/cmd Generated with Claude Code (claude-fable-5) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18.
git/cmd.Runnerprocess creation through a shared helper.CREATE_NO_WINDOWfor git child processes so console-less callers do not get visiblegit.execonsole windows.Root Cause
Runner.CommandandRunner.Runconstructedexec.CommandContext(ctx, git, ...)directly with noSysProcAttr. When a caller is launched as a console-less process on Windows, console-subsystemgit.exechildren allocate their own visible console windows unlessCREATE_NO_WINDOWis set.Validation
go test ./...git diff --checkgo.kenn.io/kit/git/cmd.Runnercalls confirmed the unpatched path created visible windows; patched path stayed quiet.